Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test alphabet and lang relation #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aurium
Copy link

@aurium aurium commented Oct 29, 2017

Using unicharadata module to help testing char alphabet.

Closes #215

@aurium
Copy link
Author

aurium commented Oct 29, 2017

Plus: I found some bad data structure, that i corrected. The tests are showing alphabet mistakes, that i leave for someone with more lang knowlege to solve. (and that is why checks will fail on travis)

@bluzi
Copy link
Owner

bluzi commented Oct 29, 2017

Hey @aurium, thanks!

The code looks great, but it doesn't seem to be so accurate. I think it's because testing every single letter is not the best approach, because there are letters that being used in multiple alphabets.

For examplt:
AssertionError [ERR_ASSERTION]: The char "c" of "алекcaндр" is LATIN, expected to be CYRILLIC (lang rus).

Don't you think?

@aurium
Copy link
Author

aurium commented Nov 8, 2017

Hi @bluzi!
I don't know about char reuse. If you are sure about the same "c" is used on Latin and Cyrillic, i can update the alphabet test to accept it. There is more other special cases?

@aurium
Copy link
Author

aurium commented Nov 12, 2017

There is more other special cases in (Cyrillic==Latin)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants