Add sex to names #474
Merged
Add sex to names #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "cmn" for Chinese.
Add aliases and translation. Merge "mitch" with "michael" because mitch is an alias for Michael. Delete "mitch.json."
Add gender to file specs in readme.md. Add tests to validate each JSON's gender value.
Resolve merge conflict by using main repo's version of JSON file.
Comment out tests for sex field. They are failing because names in collection don't have that field. Issue bluzi#443
Tests run only on name files that contain a gender value. Issue bluzi#443 Update README.md to describe sex field as optional.
Sex field now requires a value to pass test. Also: - Add error messages to explain why a test failed. - Remove test for checking whether a sex value is a string. It's duplicating part of the "should have correct structure" test.
arminkhoshbin
approved these changes
Nov 11, 2017
|
Thanks @CodeWritingCow |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #456