add instance.getValue() and instance.setValue(newVal)

[amlan-sw]

instance.setValue(newVal)

//-- regular select
newVal = 'foo';

//-- selected foo and bar option for multiple
newVal = ['foo','bar']; 

source SELECT tag will also change its value and highlight following newVal

currentVal = instance.getValue()

• currentVal is string if not multiple select
• currentVal is Array like ['foo','bar'] or ['boo'] for multiple select

Summary by Sourcery

Add methods to set and get the value of the select element, enhancing the functionality to support both single and multiple selections.

New Features:

• Introduce instance.setValue(newVal) method to set the value of the select element, supporting both single and multiple selections.
• Introduce instance.getValue() method to retrieve the current value of the select element, returning a string for single selections and an array for multiple selections.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces two new methods, setValue and getValue, to the NiceSelect class. The setValue method allows for programmatically setting the value of the select element, while the getValue method retrieves the current value. Additionally, the handling of selected options has been improved in the _onItemClicked and resetSelectValue methods to ensure more robust manipulation of the 'selected' attribute.

File-Level Changes

Files	Changes
src/js/nice-select2.js	Enhanced the NiceSelect class with new methods for setting and getting the value of the select element, and improved the handling of selected options.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @amlan-sw - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using opt.selected = false instead of delete(opt.selected) for better readability and consistency with common JavaScript practices.
• The setValue() method is quite complex, especially for handling multiple selects. Consider refactoring it into smaller, more focused functions to improve readability and maintainability.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}