Refactor: Removed throwing of SvgImageException and replaced it with …

…a EventHandler
bnoffer · Feb 28, 2023 · dc30d57 · dc30d57
1 parent 305a40b
commit dc30d57
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 3 deletions.
diff --git a/Sample/SVGSample.Android/Resources/Resource.designer.cs b/Sample/SVGSample.Android/Resources/Resource.designer.cs
diff --git a/Sample/SVGSample/App.xaml.cs b/Sample/SVGSample/App.xaml.cs
@@ -11,7 +11,11 @@ public App()
             InitializeComponent();
 
             Xamarin.Forms.Extensions.Svg.SvgImage.RegisterAssembly();
-
+            Xamarin.Forms.Extensions.Svg.SvgImage.ExceptionEvent += (sender, e) =>
+            {
+                var ex = ((Xamarin.Forms.Extensions.Svg.SvgImageExceptionEventArgs)e).SvgImageException;
+                System.Diagnostics.Debug.WriteLine(ex.Message);
+            };
             MainPage = new MainPage();
         }
 

diff --git a/XamExtensionsSvg/SvgImage.cs b/XamExtensionsSvg/SvgImage.cs
@@ -62,6 +62,12 @@ public Color TintColor
 
         #endregion
 
+        #region Event
+
+        public static EventHandler<SvgImageExceptionEventArgs> ExceptionEvent { get; set; }
+
+        #endregion
+
         #region Constructor
 
         /// <summary>
@@ -168,7 +174,7 @@ private void CanvasViewOnPaintSurface(object sender, SKPaintSurfaceEventArgs arg
             }
             catch (Exception ex)
             {
-                throw new SvgImageException($"Error while trying to load Resource {resourceId}/{Source}.", ex);
+                ExceptionEvent?.Invoke(this, new SvgImageExceptionEventArgs(new SvgImageException($"Error while trying to load Resource {resourceId}/{Source}.", ex)));
             }
         }
 

diff --git a/XamExtensionsSvg/SvgImageExceptionEventArgs.cs b/XamExtensionsSvg/SvgImageExceptionEventArgs.cs
@@ -0,0 +1,15 @@
+using System;
+namespace Xamarin.Forms.Extensions.Svg
+{
+	public class SvgImageExceptionEventArgs : EventArgs
+	{
+		private SvgImageException _svgImageException;
+		public SvgImageException SvgImageException => _svgImageException;
+
+		public SvgImageExceptionEventArgs(SvgImageException ex)
+		{
+			_svgImageException = ex;
+		}
+	}
+}
+