Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR allows for projection into LSI spaces, as planned with an sklearn-esque interface. We port over both variable feature selection, and LSI.
fit()
,project()
andshort_description()
methods have been created for both these steps.Currently the implementations utilize a lot of the previously created LSI implmementation. I am refraining from moving that over until review is concluded. However, this PR already contains some initial tests, and a demonstration that we can concat two
PipelineSteps
together, to fit and project.Tests
fit()
andproject()
methods work for variable feature selection and LSI.fit()
andproject()
working from thePipeline
implementations of these two methods