Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ia/matrix projections lsi #162

Open
wants to merge 2 commits into
base: ia/matrix-projections-predictions
Choose a base branch
from

Conversation

immanuelazn
Copy link
Collaborator

@immanuelazn immanuelazn commented Nov 18, 2024

Details

This PR allows for projection into LSI spaces, as planned with an sklearn-esque interface. We port over both variable feature selection, and LSI. fit(), project() and short_description() methods have been created for both these steps.

Currently the implementations utilize a lot of the previously created LSI implmementation. I am refraining from moving that over until review is concluded. However, this PR already contains some initial tests, and a demonstration that we can concat two PipelineSteps together, to fit and project.

Tests

  • Tests were created to make sure initialization, as well as fit() and project() methods work for variable feature selection and LSI.
  • Tests were also created to make sure pipelines can be created between these two individual steps, with fit() and project() working from the Pipeline implementations of these two methods

@immanuelazn immanuelazn marked this pull request as ready for review November 18, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant