-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: import gateway client and updated wallet logic #267
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Signed-off-by: Gregory Hill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming most of the code is copied from the current production code. Mostly lgtm but the exposed functions lack in-code function documentation
sdk/examples/gateway.ts
Outdated
const _psbtHex = hex.encode(psbt); | ||
|
||
// Sign all inputs with the payment address | ||
const signedPsbtHex = ""; // TODO: sign PSBT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the intended use case is here, if it's to be used in e.g. bots, or if it's to allow people to embed this in their UIs. If the latter, an example showing that would also be nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just example code, extracted from the UI to show partners how to integrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plan is for @derrekcoleman to use this in a React example instead
const esploraClient = new DefaultEsploraClient(network); | ||
|
||
// NOTE: esplora only returns the 25 most recent UTXOs | ||
// TODO: change this to use the pagination API and return all UTXOs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to address this before merging? Or maybe make an issue for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will make an issue
…omments Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
Add example usage