Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow extracting hash from output #298

Merged
merged 3 commits into from
Jul 31, 2024
Merged

feat: allow extracting hash from output #298

merged 3 commits into from
Jul 31, 2024

Conversation

ferencdg
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 9:17am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fc56c76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gregdhill
gregdhill requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@gregdhill gregdhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if you could also add a Solidity test case.

src/utils/BitcoinTx.sol Show resolved Hide resolved
src/utils/BitcoinTx.sol Outdated Show resolved Hide resolved
src/utils/BitcoinTx.sol Outdated Show resolved Hide resolved
src/utils/BitcoinTx.sol Show resolved Hide resolved
@ferencdg
Copy link
Contributor Author

Would be good if you could also add a Solidity test case.

I was thinking, but do you know an easy way to get a testdata?

@ferencdg ferencdg force-pushed the endre/hashExtract2 branch from 1d2ce62 to 899e151 Compare July 29, 2024 09:11
@ferencdg
Copy link
Contributor Author

Would be good if you could also add a Solidity test case.

I was thinking, but do you know an easy way to get a testdata?

Never mind, found a way

Would be good if you could also add a Solidity test case.

added

@gregdhill gregdhill merged commit 6f459d4 into master Jul 31, 2024
2 checks passed
@gregdhill gregdhill deleted the endre/hashExtract2 branch July 31, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregdhill gregdhill gregdhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferencdg @gregdhill