feat: add fee output to psbt #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Gregory Hill <[email protected]>
nud3l
reviewed
Oct 10, 2024
| outputs.push({ | ||
| // OP_RETURN https://github.com/paulmillr/scure-btc-signer/issues/26 | ||
| script: Script.encode(['RETURN', hex.decode(opReturnData)]), | ||
| script: Script.encode(['RETURN', hex.decode(stripHexPrefix(opReturnData))]), |
There was a problem hiding this comment.
Why is this necessary now and wasn't necessary before?
There was a problem hiding this comment.
It does the same thing as the code I removed above
| fee = 0; | ||
| } | ||
|
|
||
| const feeDecimal = fee / 10000; |
There was a problem hiding this comment.
I'd use big.js here. JS arithmetic with decimals is not great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some fees in case frontends want to charge users for onramping