Better fee estimation #381
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielsimao
force-pushed
the
dom/fee-estiamte
branch
from
ae6cc7f to
a4540ca
Compare
danielsimao
force-pushed
the
dom/fee-estiamte
branch
from
090e516 to
41c4657
Compare
danielsimao
force-pushed
the
dom/fee-estiamte
branch
from
41c4657 to
6a92bdc
Compare
| // TODO: Use a real P2SH-P2WPKH address | ||
| // TODO: Add the pubkey to allow spending from the outputs | ||
| // '3DFVKuT9Ft4rWpysAZ1bHpg55EBy1HVPcr', |
There was a problem hiding this comment.
Should these be addressed before merging?
There was a problem hiding this comment.
yeah, it is a test case that Dom disabled.
| } | ||
|
|
||
| // We need the public key to generate the redeem and witness script to spend the scripts | ||
| if (addressInfo.type === (AddressType.p2sh || AddressType.p2wsh)) { |
There was a problem hiding this comment.
Just to note: p2wsh is mentioned as not being supported in getInputFromUtxoAndTx
| // P2WPKH: https://blockstream.info/address/bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq | ||
| 'bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq', | ||
| // P2SH-P2WPKH: https://blockstream.info/address/3DFVKuT9Ft4rWpysAZ1bHpg55EBy1HVPcr | ||
| // TODO: As above, add a correct P2SH-P2WPKH address with its pub key |
There was a problem hiding this comment.
We should probably add this before merging, right?
Instead of relying on assumptions about the inputs, allow fee estimation to account for all possible inputs.