Enable tweak signer for taproot address #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavastartsev
requested review from
sander2,
gregdhill,
nud3l and
danielsimao
🦋 Changeset detectedLatest commit: 1a819bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
slavastartsev
commented
Nov 7, 2024
slavastartsev
force-pushed
the
feat/taproot-address
branch
from
0b663cd to
6c17b1e
Compare
sander2
reviewed
Nov 14, 2024
sander2
approved these changes
Nov 15, 2024
gregdhill
reviewed
Nov 25, 2024
There was a problem hiding this comment.
I think probably we should move the useBalance logic to the SDK where we can actually test it properly. What do you think @slavastartsev?
Right, starting to think that now that sdk might be a better place for that logic. I'll raise a PR to fix that. |
gregdhill
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.