[BUGFIX] Don't deactivate already inactive deployments (#104)

#92 Mentions errors regarding deployments having the max number of statuses already set. This PR avoids this from happening, by only setting the status if the status isn't already "inactive". Co-authored-by: Robert Lin <[email protected]>
bobheadxi · Jun 22, 2022 · 9d4477f · 9d4477f
1 parent cc8bbd0
commit 9d4477f
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 5 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/lib/deactivate.ts b/src/lib/deactivate.ts
@@ -28,15 +28,37 @@ async function deactivateEnvironment(
     log.info(
       `${environment}.${deployment.id}: setting deployment (${deployment.sha}) state to "${deactivatedState}"`
     );
-    const res = await github.rest.repos.createDeploymentStatus({
+
+    // Check existing status, to avoid setting it to the already current value.
+    // See https://github.com/bobheadxi/deployments/issues/92.
+    const getStatusRes = await github.rest.repos.listDeploymentStatuses({
+      owner,
+      repo,
+      deployment_id: deployment.id,
+      per_page: 1, // we only need the latest status
+    });
+
+    // If a previous status exists, and it is inactive, then we don't need to update it.
+    if (
+      getStatusRes.data.length === 1 &&
+      getStatusRes.data[0].state === deactivatedState
+    ) {
+      log.debug(
+        `${environment}.${deployment.id} is already ${deactivatedState}; skipping.`
+      );
+      continue;
+    }
+
+    // Otherwise, set the deployment to "inactive".
+    const createStatusRes = await github.rest.repos.createDeploymentStatus({
       owner,
       repo,
       deployment_id: deployment.id,
       state: deactivatedState,
     });
     log.debug(`${environment}.${deployment.id} updated`, {
-      state: res.data.state,
-      url: res.data.url,
+      state: createStatusRes.data.state,
+      url: createStatusRes.data.url,
     });
   }