Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace saveFrameToPng() to fix black halo on exported images #3

Merged
merged 1 commit into from
May 19, 2018

Conversation

ashikase
Copy link

NOTE: This fixes the following issues:
airbnb/lottie-web#73
airbnb/lottie-web#158

NOTE: This is an improved version of the following pull request:
#1

NOTE: This fixes the following issues:
    airbnb/lottie-web#73
    airbnb/lottie-web#158

NOTE: This is an improved version of the following pull request:
      bodymovin#1
@ashikase
Copy link
Author

As mentioned, this is a cleaned-up and augmented version of the "improve png exporting" pull request submitted by @bigxixi.

Features:

  • Uses the render queue to export images for each selected composition.
  • Overwrites any existing images from a previous export.
  • Handles a bug where "00000" gets added to the end of the exported file's name.
  • Backs up the render queue before export, and restores when finished.
  • Temporarily disables the "Save when starting render queue" option to prevent export delays.
  • Temporarily disables the "Play Sound When Render Finishes" option as it can be annoying when exporting multiple compositions.

Note that this patch was tested with the bodymovin-extension provided in the latest release of lottie-web, version 5.1.10, with Adobe After Effects CC v15.0.1 build 73.

@ashikase ashikase closed this Apr 17, 2018
@ashikase ashikase reopened this Apr 17, 2018
@bodymovin bodymovin merged commit 304e02a into bodymovin:master May 19, 2018
@bodymovin
Copy link
Owner

@ashikase Thanks for your collaboration!!
I've done some small changes and added more image features on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants