Make it so no duplicate AJAX requests are sent

Not sure if there are race conditions
bolt · Oct 9, 2023 · 662b1df · 662b1df
1 parent d72bfed
commit 662b1df
Showing 1 changed file with 16 additions and 7 deletions.
diff --git a/assets/js/app/editor/Components/Select.vue b/assets/js/app/editor/Components/Select.vue
@@ -153,19 +153,28 @@ export default {
          */
         if (this.fetchurl) {
             window.selectCache = window.selectCache || {};
+            window.requestCache = window.requestCache || {};
+
             if (window.selectCache[this.fetchurl]) {
                 this.options = window.selectCache[this.fetchurl];
                 fixSelectedItems.call(this);
-            } else {
-                this.isLoading = true;
-
-                $.ajax({ url: this.fetchurl, dataType: 'json', cache: true }).then(response => {
+            } else if (window.requestCache[this.fetchurl]) {
+                window.requestCache[this.fetchurl].then(response => {
                     this.options = response;
-                    window.selectCache[this.fetchurl] = response;
-                    this.isLoading = false;
-
                     fixSelectedItems.call(this);
                 });
+            } else {
+                this.isLoading = true;
+
+                window.requestCache[this.fetchurl] = $.ajax({ url: this.fetchurl, dataType: 'json', cache: true });
+                window.requestCache[this.fetchurl].then(
+                    response => {
+                        this.options = response;
+                        window.selectCache[this.fetchurl] = response;
+                        this.isLoading = false;
+                        fixSelectedItems.call(this);
+                    },
+                );
             }
         } else {
             fixSelectedItems.call(this);