Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Vue upgrade #2842

Draft
wants to merge 52 commits into
base: master
Choose a base branch
from
Draft

[WIP] Vue upgrade #2842

wants to merge 52 commits into from

Conversation

Joossensei
Copy link
Contributor

Working on upgrading from Vue 2 to Vue 3

@I-Valchev
Copy link
Member

Wow, awesome! Big fan of upgrading to Vue 3! 👍

@I-Valchev I-Valchev mentioned this pull request Dec 10, 2021
Open
@I-Valchev I-Valchev changed the base branch from master to 5.0 December 17, 2021 13:05
@I-Valchev I-Valchev changed the base branch from 5.0 to master December 17, 2021 13:05
@I-Valchev
Copy link
Member

Hi @Joossensei , solid progress!

A couple of questions I have:

  1. it looks like the Markdown field does not work for me:
    image

Am I missing something?

  1. Fields inside a set/collections are not working for me anymore, can you take a look?
    image

@Joossensei
Copy link
Contributor Author

Joossensei commented Jan 11, 2022 •
edited
Loading

  • Fix the markdown
  • Fix the collections
  • Fix the tests

@Joossensei Joossensei marked this pull request as ready for review January 11, 2022 15:32
@Joossensei Joossensei marked this pull request as draft January 11, 2022 15:32
Joossensei and others added 20 commits February 21, 2022 12:31
@Joossensei
Updated all packages
f5af7cf
@Joossensei
Fixed most errors
d2f23bc
@Joossensei
Update index.js
73abaf0 
use function isnt inside of Vue but inside createApp() in Vue 3
@Joossensei
Upgrade for vuex required
98bc583
@Joossensei
Updated some files and the vuedraggable
c22c502
@Joossensei
Fixed the password field on login
36cd716
@Joossensei
fixed sidebar and Toolbar
b54d121
@Joossensei
Fixing Popover, Dropdown, Toast, filters and this.$root.$on problems
0979e2d
@Joossensei
fixed dropdown
cbdbfcf
@Joossensei
Fixed some more editor component errors
aa6fbd4
@Joossensei
Bootstrap Update
90aeb25 
Bootstrap merged some of their files into one so we could remove the duplicate files
@Joossensei
Revert Bootstrap changes
3f46681 
All these changes need to be done apart from this upgrade because its a lot
@Joossensei
Bootstrap
561dcdc
@Joossensei
Reverted the bootstrap errors
380b640
@Joossensei
WIP fix for image and file list components
3fe71bf
@Joossensei
Fixed pattern and the lists render
9213542
@Joossensei
Updated packages and fixing bugs in fields
438ada1
@Joossensei
Fixing all fields
c84c250
@Joossensei
Fix space between save buttons
c25adbe
@Joossensei
Testing
8313c7a
Joossensei and others added 23 commits February 21, 2022 12:35
@Joossensei
fixed sidebar and Toolbar
6fadd4a
@Joossensei
Fixing Popover, Dropdown, Toast, filters and this.$root.$on problems
9023a49
@Joossensei
fixed dropdown
d1d8854
@Joossensei
Bootstrap Update
bea66bb 
Bootstrap merged some of their files into one so we could remove the duplicate files
@Joossensei
Revert Bootstrap changes
3a44a0f 
All these changes need to be done apart from this upgrade because its a lot
@Joossensei
Bootstrap
652f18f
@Joossensei
Reverted the bootstrap errors
c71dfb9
@Joossensei
Adressed a conflict
c9b395b
@Joossensei
Fix space between save buttons
726a101
@Joossensei
Removed empty fields for the Select and update on package-lock
82194b4
@Joossensei
Updated the markdown field
b2556bc
@Joossensei
Update markdown so it uses the textarea component
2470c6c
@Joossensei
Fixed all editor components
810ae32
@Joossensei
Fix some store issues
d5515a7
@Joossensei
We now have a actual markdown field and removed some comments
c49cda0
@Joossensei
Update eslint prettier package
228716f
@Joossensei
Update select.html.twig
ec0e1d7 
Remove dump
@Joossensei
ESLint update
503f661
@Joossensei
More ESLint fixes
3caccc8
@Joossensei
Progress for collections
76152e5
@Joossensei
Fix StyleLint
38f12d7
@Joossensei
Update contenttypes.yaml
1b6fdb9 
Revert contenttypes.yaml
@Joossensei
Added buttons to component and removed them from template
7303826
@Joossensei
Copy link
Contributor Author

Waiting for answer on https://stackoverflow.com/questions/71209589/rendering-html-with-vue-combined-inside-a-vue-component/71220388

@doenietzomoeilijk
Copy link
Contributor

@Joossensei is there any movement or outlook on movement here? The SO thread linked seems a bit dead. I'm kinda wondering, since I might have a go at getting the Markdown field going again (it looks like the current simplemde solution doesn't work so well anymore, there's a fork that still is under development and looks like a mostly-drop-in replacement, but I'm not sure if that'd clash with your work here.

@Joossensei
Copy link
Contributor Author

@doenietzomoeilijk You can always try! I didn't manage to figure out how to fix the Markdown field. But if you have an idea on how to fix it I won't stop you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: Vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joossensei @I-Valchev @doenietzomoeilijk