bonfire-networks/bonfire-app#700 bonfire-networks/bonfire-app#924

test/controllers/confirm_email_test.exs

@@ -114,13 +114,17 @@ defmodule Bonfire.UI.Me.ConfirmEmailController.Test do
     end
 
     test "success" do
+      #  create a first user since confirmation otherwise not required
+      fake_user!()
       conn = conn()
       {:ok, account} = Bonfire.Me.Accounts.signup(signup_form())
       conn = get(conn, "/signup/email/confirm/#{account.email.confirm_token}")
       assert redirected_to(conn) == "/switch-user"
     end
 
     test "cannot confirm twice" do
+      #  create a first user since confirmation otherwise not required
+      fake_user!()
       # needs template fix - no feedback
       conn = conn()
       {:ok, account} = Bonfire.Me.Accounts.signup(signup_form())

test/controllers/create_user_test.exs

@@ -183,7 +183,7 @@ defmodule Bonfire.UI.Me.CreateUserController.Test do
   end
 
   test "first user is autopromoted" do
-    Process.put([:bonfire, :env], "prod")
+    Process.put([:bonfire, :env], :prod)
 
     on_exit(fn ->
       Process.delete([:bonfire, :env])
@@ -201,7 +201,7 @@ defmodule Bonfire.UI.Me.CreateUserController.Test do
     }
 
     conn = post(conn, "/create-user", params)
-    # assert_raise RuntimeError, debug(floki_response(conn))
+    # debug(floki_response(conn))
     conn = get(recycle(conn), "/dashboard")
     doc = floki_response(conn)
     assert [ok] = find_flash(doc)

test/controllers/local_user_ban_test.exs

@@ -0,0 +1,27 @@
+defmodule Bonfire.UI.Me.Boundaries.InstanceWideGhostActorTest do
+  use Bonfire.UI.Me.ConnCase, async: true
+  # import Bonfire.Boundaries.Debug
+  alias ActivityPub.Config
+
+  test "instance-wide ghosted local user cannot switch to that or any other identity" do
+    bob = fake_account!()
+    alice_user = fake_user!(bob)
+    bob_user = fake_user!(bob)
+    Bonfire.Boundaries.Blocks.block(bob_user, :ghost, :instance_wide)
+
+    conn = conn(account: bob)
+    assert catch_throw(get(conn, "/switch-user/#{bob_user.character.username}"))
+
+    assert catch_throw(get(conn, "/switch-user/#{alice_user.character.username}"))
+
+    # assert redirected_to(conn) == "/switch-user"
+    # assert catch_throw(get(recycle(conn), "/switch-user") |> warn("swwww"))
+    conn = get(recycle(conn), "/switch-user")
+    # doc = floki_response(conn)
+    assert redirected_to(conn) == "/login"
+    # conn = get(recycle(conn), "/error")
+    # doc = floki_response(conn)
+    # assert [err] = find_flash(doc)
+    # assert_flash_kind(err, :error)
+  end
+end

test/controllers/login_test.exs

@@ -124,7 +124,7 @@ defmodule Bonfire.UI.Me.LoginController.Test do
       }
 
       conn = post(conn, "/login", params)
-      assert redirected_to(conn) == "/"
+      assert redirected_to(conn, 303) == "/"
     end
 
     test "with email for an account with multiple user identities" do
@@ -142,7 +142,7 @@ defmodule Bonfire.UI.Me.LoginController.Test do
       }
 
       conn = post(conn, "/login", params)
-      assert redirected_to(conn) == "/switch-user"
+      assert redirected_to(conn, 303) == "/switch-user"
     end
 
     test "with username" do
@@ -159,7 +159,7 @@ defmodule Bonfire.UI.Me.LoginController.Test do
       }
 
       conn = post(conn, "/login", params)
-      assert redirected_to(conn) == "/"
+      assert redirected_to(conn, 303) == "/"
     end
   end
 end

test/controllers/signup_test.exs

@@ -64,6 +64,9 @@ defmodule Bonfire.UI.Me.SignupController.Test do
   end
 
   test "can signup" do
+    #  create a first user since confirmation otherwise not required
+    fake_user!()
+
     conn = conn()
     email = email()
     password = password()
@@ -84,6 +87,8 @@ defmodule Bonfire.UI.Me.SignupController.Test do
   end
 
   test "can signup (with PhoenixTest)" do
+    #  create a first user since confirmation otherwise not required
+    fake_user!()
     conn = conn()
     email = email()
     password = password()
@@ -92,6 +97,7 @@ defmodule Bonfire.UI.Me.SignupController.Test do
     |> visit("/")
     |> click_link("Create an account")
     |> assert_has("#signup")
+    #  FIXME: button no longer exists?
     |> assert_has("#signup button", text: "Accept")
     |> fill_in("Email address", with: email)
     |> fill_in("Choose a password (10 characters minimum)", with: password)

test/controllers/switch_user_test.exs

@@ -74,7 +74,7 @@ defmodule Bonfire.UI.Me.SwitchUserController.Test do
       conn = get(conn, "/switch-user/#{user.character.username}")
       next = redirected_to(conn)
       assert next == "/"
-      conn = get(conn, next)
+      conn = get(conn, "/dashboard")
       assert get_session(conn, :current_user_id) == user.id
       doc = floki_response(conn)
       # debug(doc)

test/views/settings_test.exs

@@ -179,7 +179,7 @@ defmodule Bonfire.UI.Me.SettingsTest do
       |> render_change(%{"ui" => %{"compact" => "true"}})
 
       # force a refresh
-      {:ok, refreshed_view, _html} = live(conn, "/")
+      {:ok, refreshed_view, _html} = live(conn, "/dashboard")
 
       # open_browser(refreshed_view)
       assert refreshed_view
@@ -241,7 +241,7 @@ defmodule Bonfire.UI.Me.SettingsTest do
         "Bonfire.UI.Common.BadgeCounterLive" => %{"highlight" => "true"}
       })
 
-      {:ok, refreshed_view, _html} = live(conn, "/")
+      {:ok, refreshed_view, _html} = live(conn, "/dashboard")
       # open_browser(refreshed_view)
 
       auto_assert refreshed_view