Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch for AIX #78

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

patch for AIX #78

wants to merge 1 commit into from

Conversation

tjcw
Copy link

@tjcw tjcw commented Nov 5, 2024

This PR adds support for openxl and xlclang toolchains on AIX

@pdimov
Copy link
Member

pdimov commented Nov 5, 2024

I assume this is dependent on boostorg/build#778, which should presumably be re-issued against the upstream https://github.com/bfgroup/b2?

@tjcw
Copy link
Author

tjcw commented Nov 5, 2024

I raised the PR on the repository where the affected files were. Should I raise an issue in the b2 repository pointing to this PR ?

@pdimov
Copy link
Member

pdimov commented Nov 5, 2024

If you're asking whether you need to open a pull request in https://github.com/bfgroup/b2, the answer is yes, that's the main repository for b2 nowadays. boostorg/build is updated regularly from bfgroup/b2.

@tjcw
Copy link
Author

tjcw commented Nov 5, 2024

OK, raised in that repo as bfgroup/b2#421

@pdimov
Copy link
Member

pdimov commented Nov 5, 2024

No, that's not what I meant. The changes to b2 in boostorg/build#778 need to be raised against bfgroup/b2, not the Boost-specific bootstrap changes.

@tjcw
Copy link
Author

tjcw commented Nov 6, 2024

OK, raised as bfgroup/b2#422

@tjcw
Copy link
Author

tjcw commented Nov 12, 2024

The tests that failed were not due to the code change in this PR. One test timed out at 60 minutes, presumably because MSVC was slow. The other 2 failures were environment-related; the test needed a zip/unzip command which was unable to be installed.

Please retest as appropriate.

@pdimov
Copy link
Member

pdimov commented Nov 12, 2024

Yes, I knew that these failures weren't caused by the change in this PR. They were caused by problems in Log and Iostreams, which have been now fixed.

But I don't think there's any need to merge this PR before the changes to b2, because without them, the b2 toolset can never be xlclang or openxl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants