-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed incorrect callbacks to finish_edge in undirected_dfs #390
fixed incorrect callbacks to finish_edge in undirected_dfs #390
Conversation
Not sure why all those Drone checks failed, but you probably should update to the tip of |
Please add a unit test that would fail on |
stack.push_back(std::make_pair(u, | ||
std::make_pair(src_e, std::make_pair(++ei, ei_end)))); | ||
std::make_pair(src_e, std::make_pair(ei+1, ei_end)))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably has to be this so that it works with edge iterators that aren't random access.
std::make_pair(src_e, std::make_pair(ei+1, ei_end)))); | |
std::make_pair(src_e, std::make_pair(std::next(ei), ei_end)))); |
And, call me fussy, but I prefer this style anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, makes sense! I'm not very fluent in C++, so thanks for pointing this out :)
2438fa9
to
b671e3d
Compare
I added a unit test now based on the minimal working example in #389. I tested the test hehe and it passes with the changes I made and fails without these changes. Disclaimer: I know my coding style is quite different from what mostly prevails in this codebase. So feel free to adapt anything you think is important for maintaining consistency. Similarly, as C++ is not my main coding language, I'm sure there are quite a few things someone with more experience would have done better or differently. So feel free to make changes in this regard too :) Not sure though how the workflow here on Github is and whether you need write access to my fork to be able to make edits... |
Huh, that's weird, the GitHub actions CI doesn't seem to be running, and the Drone CI ran instantly. :| |
Thanks again! |
I was happy with the implementation, so I merged it, but actually the test could do with some improvement if you have time. |
Resolves #389