-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hashable] hana::integral_constant with an enum value implements Hashable #440
base: develop
Are you sure you want to change the base?
[Hashable] hana::integral_constant with an enum value implements Hashable #440
Conversation
I think CI failed because it found trailing spaces. The github site doesn't seem to reflect that though.
|
Indeed, good catch ! I corrected them. |
lgtm, but please "fixup" the commit so there is one commit. @ldionne is currently at a standards committee meeting, so I don't know when he will look at this. |
864e975
to
64a9a40
Compare
Sorry, I thought it was only for local commits ! Done :) |
Do you have any progress on that PR? |
I would like to have this feature, too |
> { | ||
template <typename X> | ||
static constexpr auto apply(X const&) { | ||
return hana::type_c<X>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just taking a second look at this, is there a reason it does not normalize to hana::type<hana::integral_constant<T, X::value>
as the others do?
Hi, this is my first contribution to Boost.Hana, so please tell me my mistakes :)
This small change implements Hashable for hana::integral_constant with an enumeration value :
It allows for example to use enumeration values as key for hana::map.