Make BOOST_STRONG_TYPEDEF constexpr #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suppose we make this change. What happens when we use it with a compiler which does not support constant expressions? I think this needs to be more elaborate to be totally portable. I see merit in the idea, but I don't see it being portable to all compilers that the boost serialization library supports. FYI. The serialization library no longer uses this macro. It's been left in there as it seems that many find it useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lack of constexpr constructor for BOOST_STRONG_TYPEDEF cause errors in clang and warning in gcc when using in constexpr functions.