Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOOST-4792] ci(examples): keep hardhat process alive, kill afterwards #189

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[BOOST-4792] ci(examples): keep hardhat process alive, kill afterwards #189

wants to merge 10 commits into from

Conversation

sammccord
Copy link
Contributor

@sammccord sammccord commented Oct 9, 2024 •
edited
Loading

🚨 Please review the guidelines for contributing to this repository.

Description

This pr only kills the hardhat process during tests if no HARDHAT_KEEPALIVE env var exists
After the turbo process exits, kill the process regardless of whether it passed or not

fix #157

💔 Thank you!

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c38ba7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sammccord sammccord changed the title ci(examples): keep hardhat process alive, kill afterwards [BOOST-4792] ci(examples): keep hardhat process alive, kill afterwards Oct 9, 2024
@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 0579211

@sammccord sammccord force-pushed the sam/boost-4792-fix-figure-out-way-to-manage-hardhat-process-to-run-all branch from 0579211 to 66b4a3b Compare October 9, 2024 17:15
@sammccord sammccord force-pushed the sam/boost-4792-fix-figure-out-way-to-manage-hardhat-process-to-run-all branch from 66b4a3b to fdad0a8 Compare October 9, 2024 17:17
@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against fdad0a8

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 0442063

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 18cd1b8

@sammccord sammccord force-pushed the sam/boost-4792-fix-figure-out-way-to-manage-hardhat-process-to-run-all branch from 18cd1b8 to bb9cf68 Compare October 10, 2024 14:35
@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against bb9cf68

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against afc0b97

@sammccord
ci(examples): keep hardhat process alive, kill afterwards
05c4db9 
chore: tryfix use-case test comand

chore: try running node globally, longer timeouts

ci(fix): use OpenAllowlist
@sammccord sammccord force-pushed the sam/boost-4792-fix-figure-out-way-to-manage-hardhat-process-to-run-all branch from afc0b97 to 05c4db9 Compare November 6, 2024 15:08
@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 05c4db9

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against fd48b88

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against df77b40

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against f23bd0b

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 563797e

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 4c599f8

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 454287d

@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 638b436

@github-actions github-actions bot added the SDK label Nov 6, 2024
@sammccord
Copy link
Contributor Author

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against c38ba7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathandiep jonathandiep jonathandiep approved these changes

@mmackz mmackz Awaiting requested review from mmackz

Assignees
No one assigned
Labels
examples SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: figure out way to manage hardhat process to run all examples/* tests in ci
2 participants
@sammccord @jonathandiep