Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm): add delegated claims interface #42

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

topocount
Copy link
Contributor

@topocount topocount commented Aug 29, 2024

This facilitates autoclaims

Still needs to be E2E tested, just wanted to get it in here

merge plan

merge after #41

Copy link
Collaborator

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if we even need to do much in the way of testing - maybe something light but we could also just use this path a few times in the net-new claim tests

packages/evm/contracts/BoostCore.sol Outdated Show resolved Hide resolved
@topocount
Copy link
Contributor Author

Idk if we even need to do much in the way of testing - maybe something light but we could also just use this path a few times in the net-new claim tests

Yeah I think this can easily be included in e2e tests this weekend or Monday

This facilitates autoclaims

Still needs to be E2E tested, just wanted to get it in here
@topocount topocount changed the base branch from signer-validator-eip712 to main September 3, 2024 18:02
@topocount topocount enabled auto-merge (rebase) September 3, 2024 18:03
@topocount topocount marked this pull request as draft September 3, 2024 18:05
auto-merge was automatically disabled September 3, 2024 18:05

Pull request was converted to draft

@topocount topocount marked this pull request as ready for review September 3, 2024 18:05
@topocount topocount enabled auto-merge (rebase) September 3, 2024 18:10
@topocount topocount merged commit ef7633a into main Sep 3, 2024
3 checks passed
@topocount topocount deleted the add-delegated-claim-interface branch September 3, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants