test(evm): Add fuzz tests for SignerValidator #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quazia
approved these changes
Sep 3, 2024
| address claimant, | ||
| bytes memory incentiveData | ||
| ) public { | ||
| incentiveQuantity = uint8(bound(incentiveQuantity, 1, 7)); |
There was a problem hiding this comment.
This should work up to 8, right? It's the ID that needs to be under 8 necessarily
| validator.validate(boostId, incentiveId, claimant, claimData); | ||
| } | ||
|
|
||
| function testValidate_FuzzMaliciousSignature( |
There was a problem hiding this comment.
We probably want to add another fuzz test for malicious signature generation vs signer generation and rename this but this one looks good.
topocount
force-pushed
the
validation-auth
branch
3 times, most recently
from
fd894f7
to
e4ed633
Compare
These fuzz tests cover signature spoofing and also sets of inputs that should work validate successfully. We could go in harder on the signature spoofing if we wanted to by constraining stack parameters and fuzzing on claimData though.
topocount
force-pushed
the
signervalidator-fuzz
branch
from
fae143d
to
2f97e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fuzz tests cover signature spoofing and also sets of inputs
that should work validate successfully.
We could go in harder on the signature spoofing if we wanted to by
constraining stack parameters and fuzzing on claimData though.
merge plan
merge after #45