Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello @looooo,
I hope you're doing well! I've just opened this pull request that proposes the removal of the unused
lxml
dependency from thesetup.py
configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.Rationale
The
lxml
library was introduced in 6f6a83a. However it appears to be unused in the source code. It was added on the grounds that it was required indirectly byezodf
. However, it is already listed inezodf
s dependencies, making its declaration inOpenGlider
redundant.Instead, when
OpenGlider
is installed through pip (e.g.pip install -e .
), pip will automatically resolvelxml
throughezodf
.Removing this unused dependency will mitigate potential security risks and, most importantly, simplify the dependency management process.
Changes
lxml
dependency from thesetup.py
file..travis.yaml
to reflect on this changeImpact
Reduced package size: Eliminating this unused dependency will decrease the overall size of the installed packages.
Simplified dependency tree: A leaner list of dependencies aids in more straightforward project maintenance and faster installations.