Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Dependency: lxml #74

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gdrosos
Copy link

@gdrosos gdrosos commented Sep 4, 2023

Summary

Hello @looooo,

I hope you're doing well! I've just opened this pull request that proposes the removal of the unused lxml dependency from the setup.py configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The lxml library was introduced in 6f6a83a. However it appears to be unused in the source code. It was added on the grounds that it was required indirectly by ezodf. However, it is already listed in ezodfs dependencies, making its declaration in OpenGlider redundant.

Instead, when OpenGlider is installed through pip (e.g. pip install -e .), pip will automatically resolve lxml through ezodf.

Removing this unused dependency will mitigate potential security risks and, most importantly, simplify the dependency management process.

Changes

  • Removed the lxml dependency from the setup.py file.
  • Updated .travis.yaml to reflect on this change

Impact

  • Reduced package size: Eliminating this unused dependency will decrease the overall size of the installed packages.

  • Simplified dependency tree: A leaner list of dependencies aids in more straightforward project maintenance and faster installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant