Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New repositories use "main" as default branch name #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

etho201
Copy link

@etho201 etho201 commented Nov 5, 2020

PR Details

New repositories use main as default branch name.

Description

I ran into issues going through the SDP learning lab because I assumed it was safe to keep my branch defined as master. Once I inspected my repository I noticed that GitHub now uses main as the default branch name for new repositories.

More info can be found here:
https://github.com/github/renaming

How Has This Been Tested

I did not test this change, but can confirm that new repositories use main by default and this may stump new users who are following the SDP learning lab.

Types of Changes

  • Added Unit Testing
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added the appropriate label for this PR
  • If necessary, I have updated the documentation accordingly.
  • All new and existing tests passed.

@cokieffebah
Copy link
Contributor

@etho201 Thanks for bringing this to our attention. Since you mentioned the 'master' vs 'main', I suspect a change is needed in the documentation for the learning labs. If you don't mind, where in the learning labs did you encounter the name issue?

Also,I suggest that you run some testing before submitting a PR. You updated the branch name in a stub on unit tests, but I suspect those tests still worked regardless of the 'master' branch name. Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants