Skip to content

Commit

Permalink
Assets-builder refactoring (#376)
Browse files Browse the repository at this point in the history
* add `options.workspace` draft for future implementation

* add workspace metadata, fix: use `PackageIdSpec` instead of `PackageId` in some places

* improvements, assets-plan display fmt, less lifetimes

* small fixes, reduce `Package` using where just id needed

* partially rewritten assets-builder: now lazy, supports dependencies, supports cargo's auto-targets (#355);
prototype of usage new source of unit-tree

* apply clippy suggestions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* ~fixes

* fmt

* CI: reviewdog can fail on windows 🤷🏻‍♂️

* fix missed assets for dev target

* update deps, improve method names, impl manifest validation for specified target

* impl structural inheritance for `package.metadata.playdate.options` by `workspace.metadata.playdate.options`

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
boozook and github-actions[bot] authored Jun 9, 2024
1 parent 6392370 commit 5a6be83
Show file tree
Hide file tree
Showing 23 changed files with 1,455 additions and 336 deletions.
1 change: 1 addition & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ jobs:

- name: Suggestions
uses: reviewdog/action-suggester@v1
continue-on-error: ${{ runner.os == 'Windows' }} # sometimes reviewdog fails on windows
with:
filter_mode: diff_context
fail_on_error: false
Expand Down
Loading

0 comments on commit 5a6be83

Please sign in to comment.