fix(inaka#312): fix atom naming convention regex

bormilan · Sep 11, 2024 · 2eaece1 · 2eaece1
1 parent 7d7ac44
commit 2eaece1
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/src/elvis_style.erl b/src/elvis_style.erl
@@ -195,7 +195,7 @@ default(no_common_caveats_call) ->
            {timer, send_interval, 3},
            {erlang, size, 1}]};
 default(atom_naming_convention) ->
-    #{regex => "^([a-z][a-z0-9]*_?)*(_SUITE)?$", enclosed_atoms => ".*"};
+    #{regex => "^([a-z][a-z0-9]*_?)*[a-z0-9]+(_SUITE)?$", enclosed_atoms => ".*"};
 %% Not restrictive. Those who want more restrictions can set it like "^[^_]*$"
 default(numeric_format) ->
     #{regex => ".*",

diff --git a/test/examples/fail_atom_naming_convention.erl b/test/examples/fail_atom_naming_convention.erl
@@ -12,4 +12,5 @@ for_test() ->
     '\'\'',
     '\'startswithbacktick',
     'backtick\'inside',
-    'backtick at the end\''.
+    'backtick at the end\'',
+    non200_.
diff --git a/test/examples/pass_atom_naming_convention.erl b/test/examples/pass_atom_naming_convention.erl
@@ -5,4 +5,5 @@
 for_test() ->
     this_is_an_ok_atom,
     'and_so_is_this',
-    'and_this_1_too'.
+    'and_this_1_too',
+    non_200.
diff --git a/test/style_SUITE.erl b/test/style_SUITE.erl
@@ -1302,7 +1302,7 @@ verify_atom_naming_convention(Config) ->
     Group = proplists:get_value(group, Config, erl_files),
     Ext = proplists:get_value(test_file_ext, Config, "erl"),
 
-    BaseRegex = "^([a-z][a-z0-9_]+)$",
+    BaseRegex = "^([a-z][a-z0-9_]+[a-z0-9])$",
 
     % pass
     PassModule = pass_atom_naming_convention,
@@ -1337,37 +1337,37 @@ verify_atom_naming_convention(Config) ->
     FailModule2 = fail_atom_naming_convention_exception_class,
     FailPath2 = atom_to_list(FailModule2) ++ "." ++ Ext,
 
-    [_, _, _, _, _, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => BaseRegex, enclosed_atoms => same},
                               FailPath),
-    [_, _, _, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => "^([a-zA-Z_]+)$", enclosed_atoms => same},
                               FailPath),
-    [_, _] =
+    [_, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => "^([a-zA-Z_' \\\\]+)$", enclosed_atoms => same},
                               FailPath),
-    [_, _, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => "^([a-zA-Z\-_]+)$", enclosed_atoms => same},
                               FailPath),
-    [_] =
+    [_, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => "^([a-zA-Z\-_' \\\\]+)$", enclosed_atoms => same},
                               FailPath),
-    [] =
+    [_] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
@@ -1422,7 +1422,7 @@ verify_atom_naming_convention(Config) ->
                                             enclosed_atoms => "^([\\\\][\-a-z0-9A-Z_' \\\\]*)$"},
                                           FailPath);
             erl_files ->
-                [_, _, _, _, _] =
+                [_, _, _, _, _, _] =
                     elvis_core_apply_rule(Config,
                                           elvis_style,
                                           atom_naming_convention,