Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasmer web assembly submodule and a POC engine #2132

Draft
wants to merge 1 commit into
base: v0.x.x
Choose a base branch
from

Conversation

hewison-chris
Copy link
Contributor

The wasmer-d submodule supports running web assembly outside of the web browser. The class node/WasmEngine.d provides a POC engine to run web assembly programs within agora.
This is still very much a work in progress. There are some unit tests that can be used to experiment.

Copy link
Contributor

@linked0 linked0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start!

source/agora/node/WasmEngine.d Outdated Show resolved Hide resolved
@hewison-chris hewison-chris marked this pull request as draft June 2, 2021 01:21
@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch from 58f5998 to 0d21689 Compare June 11, 2021 03:17
@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch 6 times, most recently from cc72153 to 63465a7 Compare June 28, 2021 00:58
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #2132 (cd8dd9c) into v0.x.x (c4769ec) will decrease coverage by 0.15%.
The diff coverage is 98.48%.

❗ Current head cd8dd9c differs from pull request most recent head b5cfa4d. Consider uploading reports for the commit b5cfa4d to get more accurate results

@@            Coverage Diff             @@
##           v0.x.x    #2132      +/-   ##
==========================================
- Coverage   88.11%   87.95%   -0.16%     
==========================================
  Files         164      147      -17     
  Lines       16934    14041    -2893     
==========================================
- Hits        14921    12350    -2571     
+ Misses       2013     1691     -322     
Flag Coverage Δ
integration ?
unittests 87.95% <98.48%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/node/WasmEngine.d 98.48% <98.48%> (ø)
source/scpd/types/Stellar_SCP.d 54.54% <0.00%> (-44.68%) ⬇️
source/scpd/scp/SCPDriver.d 33.33% <0.00%> (-41.67%) ⬇️
source/agora/consensus/state/UTXODB.d 62.50% <0.00%> (-35.28%) ⬇️
source/agora/utils/InetUtils.d 48.71% <0.00%> (-26.29%) ⬇️
source/scpd/types/Utils.d 22.22% <0.00%> (-19.45%) ⬇️
source/agora/common/ManagedDatabase.d 78.94% <0.00%> (-12.72%) ⬇️
source/agora/consensus/data/ValidatorBlockSig.d 88.88% <0.00%> (-11.12%) ⬇️
source/agora/network/Client.d 82.29% <0.00%> (-10.99%) ⬇️
source/agora/utils/PrettyPrinter.d 89.20% <0.00%> (-9.98%) ⬇️
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4769ec...b5cfa4d. Read the comment docs.

@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch 3 times, most recently from 1bc36ac to 3f71f67 Compare June 28, 2021 06:37
@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch from 3f71f67 to cd8dd9c Compare July 26, 2021 00:13
@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch 2 times, most recently from 691d2d8 to 4cde26b Compare December 23, 2021 04:35
@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch from 4cde26b to 748d5ad Compare March 11, 2022 06:36
@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch 3 times, most recently from aa267ff to a471d7e Compare March 29, 2022 04:03
@Geod24
Copy link
Collaborator

Geod24 commented Mar 31, 2022

FYI things should run on Alpine since v2: wasmerio/wasmer@ea4ea47

@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch from a471d7e to ef11b23 Compare March 31, 2022 23:28
@Geod24
Copy link
Collaborator

Geod24 commented Apr 1, 2022

This adds the wasmer-d submodule and an engine which can run in d at
runtime. Currently the Engine is only run in the unit tests in
`WasmEngine.d` to experiment with running Web Assembly programs.
`dtest=WasmEngine dub test`
@hewison-chris hewison-chris force-pushed the issue1648_webassembly_engine_POC branch from ef11b23 to b5cfa4d Compare April 12, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trust Contracts - POC for a WebAssembly engine
3 participants