Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log for the result of Flash transactions #2906

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

linked0
Copy link
Contributor

@linked0 linked0 commented Jan 24, 2022

This is needed to analyze the failure of the operations on Flash channels.

Part of #2425

This is needed to analyze the failure of the operations
on Flash channels.
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #2906 (6952571) into v0.x.x (2775a87) will increase coverage by 3.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x    #2906      +/-   ##
==========================================
+ Coverage   78.98%   82.10%   +3.12%     
==========================================
  Files         207      193      -14     
  Lines       18175    17462     -713     
==========================================
- Hits        14355    14338      -17     
+ Misses       3820     3124     -696     
Flag Coverage Δ
integration 22.95% <ø> (+4.41%) ⬆️
unittests 87.59% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/flash/Channel.d 86.39% <100.00%> (ø)
source/scpd/types/Stellar_SCP.d 57.73% <0.00%> (-30.93%) ⬇️
source/agora/network/Manager.d 78.32% <0.00%> (-0.29%) ⬇️
agora/submodules/ocean/src/ocean/core/Buffer.d
agora/submodules/ocean/src/ocean/core/Test.d
agora/submodules/ocean/src/ocean/math/IEEE.d
...ora/submodules/ocean/src/ocean/core/array/Search.d
agora/submodules/ocean/src/ocean/core/Verify.d
agora/submodules/ocean/src/ocean/core/BitArray.d
agora/submodules/ocean/src/ocean/core/Enforce.d
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2775a87...6952571. Read the comment docs.

@linked0 linked0 requested a review from hewison-chris January 25, 2022 00:06
Copy link
Contributor

@hewison-chris hewison-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hewison-chris hewison-chris enabled auto-merge (rebase) January 25, 2022 01:08
@hewison-chris hewison-chris merged commit 1956d77 into bosagora:v0.x.x Jan 25, 2022
@linked0 linked0 deleted the issue2425-add-log branch January 25, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants