You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A flash test sometimes fails during gossipChannelsOpen if the call to getBlock fails. This can happen if the discovered channel height is
greater than the current block height of the peer we attempt to fetch
from. By storing the last block rather than block height we can help
prevent this sort of race condition.
2022-02-14 13:26:59,384 Error [agora.flash.Node] - Exception thrown from `getBlock` while gossipping: geod24.LocalRest.ClientException@submodules/localrest/source/geod24/LocalRest.d-mixin-1242(1262): Request to const(Block) geod24.LocalRest.RemoteAPI!(TestAPI, Serializer).RemoteAPI.getBlock(ulong _param_0) @safe couldn't be processed : vibe.http.common.HTTPStatusException@source/agora/node/FullNode.d(995): No block at requested height
A flash test sometimes fails during `gossipChannelsOpen` if the call to
`getBlock` fails. This can happen if the discovered channel height is
greater than the current block height of the peer we attempt to fetch
from. By storing the last block rather than block height we can help
prevent this sort of race condition.
I dont think this will help, pushBlock is called by the same Agora node that we query with the getBlock. If getBlock fails, that agora node would have never called pushBlock on our Flash node anyways since it does not have that block.
I dont think this will help, pushBlock is called by the same Agora node that we query with the getBlock. If getBlock fails, that agora node would have never called pushBlock on our Flash node anyways since it does not have that block.
But it does happen (see the log line in the description).
Is it not possible that a different node is calling pushBlock to the node we call getBlock in gossipChannelsOpen?
Is it not possible that a different node is calling pushBlock to the node we call getBlock in gossipChannelsOpen?
Ah it is, we configure Agora to push to all Flash nodes (see flashTestConf). That is not how the real world configuration will look like tho. But the race condition is still there, we may receive the channel open event before the block
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A flash test sometimes fails during
gossipChannelsOpenif the call togetBlockfails. This can happen if the discovered channel height isgreater than the current block height of the peer we attempt to fetch
from. By storing the last block rather than block height we can help
prevent this sort of race condition.