-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quorum pre-image unit test #3182
base: v0.x.x
Are you sure you want to change the base?
Fix quorum pre-image unit test #3182
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.x.x #3182 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 165 165
Lines 17131 17131
=======================================
Hits 15192 15192
Misses 1939 1939
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
edc2eeb
to
4fa452f
Compare
This test is never failing locally so is really hard to fix at the moment. |
If this fails again on CI even with this change, How about solving this problem with other approaches later. |
But if you think there are any improvements in the test result, it's not bad to merge it. |
f13fa34
to
c05fa03
Compare
905f495
to
80e9ac5
Compare
47cdc41
to
5db20f9
Compare
4116762
to
fdc6b0a
Compare
fdc6b0a
to
f797d13
Compare
The max listeners should be the sum of the validators, fullnodes and registry. In `base.d` it is correctly calculated so just remove the `testConf` hardcoded setting.
The test relies on the fact that all Genesis and outsider validators are enrolled in the last block of the cycle. Let's just assert this is the case. Maybe we will need to refactor the test if this assert fails.
These steps should not be required as the next step has retries.
For blocks 21 -> 39 it is better to send the tx to one client and check for the height in the test code as there are outsider validators. In the `generateBlocks` function it checks that the txs are gossiped to all the validators before setting the time for the next block. But as the outsiders were not enrolled until block 20 the client may gossip the tx before it has updated the peers it sends to. Normally this does not matter because once an envelope is recieved by the newly enrolled node it will try to fetch it.
If we use auto enroll then we do not need to manually enroll the outsiders for their second enrollment.
f797d13
to
ba7f961
Compare
This test has often failed recently. See commits for details on fix.