Apply the changed requirement for the Admin endpoints #3294
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.x.x #3294 +/- ##
==========================================
+ Coverage 87.83% 88.84% +1.00%
==========================================
Files 164 165 +1
Lines 16964 17081 +117
==========================================
+ Hits 14901 15176 +275
+ Misses 2063 1905 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
source/agora/api/Admin.d
Outdated
|
|
||
| Log in to the admin server | ||
|
|
||
| This is dummy endpoint for checking the username and password in |
There was a problem hiding this comment.
| This is dummy endpoint for checking the username and password in | |
| This is endpoint used only for checking the username and password in |
There was a problem hiding this comment.
Updated in next commit btw
There was a problem hiding this comment.
Ah, I will update, Thanks.
| // GET: /login | ||
| public override void login () | ||
| { | ||
| } |
There was a problem hiding this comment.
Here we should use the AUTH header to find out if user id and password are correct.
There was a problem hiding this comment.
We use AUTH header for all the requests. So I introduced the dummy endpoint. It will return an HTTP Status Code(200 or 401). But, I will find a more reasonable way to handle as you mean and the requirement is described.
bool checkPassword (string user, string password) @safe
{
return user == config.admin.username && password == config.admin.pwd;
}
auto adminrouter = new URLRouter();
adminrouter.any("*", performBasicAuth("Agora Admin", &checkPassword));
There was a problem hiding this comment.
After thinking more about this we should probably return a JWT which can be used on the subsequent requests to the other endpoints. But for now I think what you have is ok to proceed.
Added the new
loginendpoint and changed the name and return value for the existingvalidatorandencriptionkeyendpoints.Relates #3280