Add NRVO tests and make SCP types serializable with the serializer #687
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.x.x #687 +/- ##
===========================================
- Coverage 88.53% 51.20% -37.33%
===========================================
Files 146 39 -107
Lines 13989 2113 -11876
===========================================
- Hits 12385 1082 -11303
+ Misses 1604 1031 -573
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The prettify PR I made has some tests you can borrow from. |
source/agora/test/NRVO.d
Outdated
| /// Check that `self is &this` | ||
| public void check (string message, int line = __LINE__) const | ||
| { | ||
| if (ptr(this.self) !is ptr(this)) |
There was a problem hiding this comment.
would this.self !is ptr(this) not work?
|
Fixes #691 |
|
I have update this to the HEAD of my current WIP, if anyone's interested in looking at where it's heading towards. |
Thou shall not copy in vain.
This is a requirement for switching away from Vibe.d's REST module.
This is still a WIP, I want to add some sensible data in
SCPStatement.I also have an idea to systematically test NRVO on struct, I just need a bit of time.