Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of a contract to exchange ERC20 tokens from different networks #30

Merged
merged 6 commits into from
Aug 16, 2022

Conversation

MichaelKim20
Copy link
Member

@MichaelKim20 MichaelKim20 commented Aug 12, 2022

  1. The code of the smart contract became too big to compile, so I coded the necessary error message.
  2. I added a tokenId to distinguish tokens.
    The tokenId is calculated as the address of the bridge, the name of the token, and the token's symbol.
bytes32 tokenId = sha256(abi.encodePacked(address(this), token.name(), token.symbol()));
  1. Fees for transactions are collected as native tokens.

The rest are the same as BOAToken Bridge.

Related to #31

Copy link
Contributor

@Kang-Simon Kang-Simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelKim20 MichaelKim20 merged commit 89e2ceb into v0.x.x Aug 16, 2022
@MichaelKim20 MichaelKim20 deleted the token-bridge branch August 16, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants