Python3 compatibility #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under python3, we are responsible for decoding and encoding. The implementation does not change the behaviour for python 2, and by default uses python2-esque behaviour (using sys.getdefaultencoding()) under python 3, but lets the user override the encoding or even set it to None to get bytes objects back. It also allows the user to pass bytes objects to put, striking the best balance between backwards compatibility for binary data in tubes (which can never be achieved 100%) and working nicely with text data. Tested with python 2.4, 2.7 and 3.4
nyanshell
approved these changes
Mar 1, 2017
mrluanma
approved these changes
Mar 1, 2017
triostones
approved these changes
Mar 1, 2017
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try it.
earl#13
earl#60