Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make tryRestoreUsingAccessTokenCache in Box API connection public #1272

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat: make tryRestoreUsingAccessTokenCache in Box API connection public #1272

merged 1 commit into from
Nov 20, 2024

Conversation

davigotxi
Copy link
Contributor

Refs: #1271

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@davigotxi davigotxi changed the title feat: allow to modify the underlying okHttpClient from the BoxApiConnection subclasses feat: allow to modify the underlying http client from the box api connection subclasses Nov 11, 2024
@davigotxi davigotxi changed the title feat: allow to modify the underlying http client from the box api connection subclasses feat: allow to modify the underlying OkHttpClient from the box api connection subclasses Nov 11, 2024
@davigotxi davigotxi changed the title feat: allow to modify the underlying OkHttpClient from the box api connection subclasses feat: allow to modify the underlying client from the box api connection subclasses Nov 11, 2024
@congminh1254 congminh1254 changed the title feat: allow to modify the underlying client from the box api connection subclasses feat: allow to modify the underlying client from the Box API connection subclasses Nov 12, 2024
@congminh1254
Copy link
Member

Hi @davigotxi

Thanks for your contribution, currently the build is failing, please review the it.

@davigotxi davigotxi force-pushed the 1271-modify-okhttpclientbuilder branch from 3bb5be5 to 8c67b7a Compare November 12, 2024 10:48
@davigotxi
Copy link
Contributor Author

davigotxi commented Nov 12, 2024 •
edited
Loading

Hi @davigotxi

Thanks for your contribution, currently the build is failing, please review the it.

Thanks @congminh1254! That should be fixed now

@coveralls
Copy link

Pull Request Test Coverage Report for Build #4076

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 71.771%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/SharedLinkAPIConnection.java 0 1 0.0%
Totals Coverage Status
Change from base Build #4057: 0.03%
Covered Lines: 8052
Relevant Lines: 11219
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #4110

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 71.761%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
src/main/java/com/box/sdk/BoxDeveloperEditionAPIConnection.java 1 53.22%
Totals Coverage Status
Change from base Build #4085: -0.002%
Covered Lines: 8048
Relevant Lines: 11215
💛 - Coveralls

@davigotxi davigotxi marked this pull request as draft November 13, 2024 03:30
@davigotxi davigotxi force-pushed the 1271-modify-okhttpclientbuilder branch from 8c67b7a to a84c1cd Compare November 13, 2024 03:44
@davigotxi davigotxi changed the title feat: allow to modify the underlying client from the Box API connection subclasses feat: allow to modify the underlying okHttpClient from the BoxDeveloperEditionAPIConnection when using factory method Nov 13, 2024
@davigotxi davigotxi marked this pull request as ready for review November 13, 2024 03:46
@davigotxi davigotxi changed the title feat: allow to modify the underlying okHttpClient from the BoxDeveloperEditionAPIConnection when using factory method feat: allow to modify the underlying client from the connection when using factory method Nov 13, 2024
@davigotxi
feat: allow to modify the underlying okHttpClient from the BoxDevelop…
1f3ddff 
…erEditionAPIConnection when using factory method
@davigotxi davigotxi force-pushed the 1271-modify-okhttpclientbuilder branch from a84c1cd to 1f3ddff Compare November 20, 2024 02:54
@congminh1254 congminh1254 changed the title feat: allow to modify the underlying client from the connection when using factory method feat: make tryRestoreUsingAccessTokenCache in Box API connection public Nov 20, 2024
@congminh1254 congminh1254 merged commit c9f77de into box:main Nov 20, 2024
11 of 12 checks passed
congminh1254 added a commit that referenced this pull request Nov 20, 2024
@congminh1254 @davigotxi
feat: make tryRestoreUsingAccessTokenCache in Box API connection pu…
50f5a61 
…blic (#1272)

Co-authored-by: David Mondejar <[email protected]>
@mwwoda
Copy link
Contributor

mwwoda commented Nov 22, 2024

Released in 4.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congminh1254 congminh1254 congminh1254 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davigotxi @CLAassistant @congminh1254 @coveralls @mwwoda