Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added label field to TemplateSigner schema #447

Closed
wants to merge 1 commit into from

Conversation

goome126
Copy link

Description

Please include a summary of the change and which issue is fixed.

Added the label field to the TemplateSigner schema in the OpenAPI spec. When calling the list sign templates or get sign template by id endpoints of the Box API the sign template object that is returned contains Signer objects that contain a field called label that is undocumented in the OpenAPI spec.

curl -L -X GET "https://api.box.com/2.0/sign_templates?limit=1000" \ -H "authorization: Bearer <ACCESS_TOKEN>" \

{
	"type": "sign-template",
	"id": ...,
         ...,
	"signers": [
		{
			"email": "",
			>"label": "",
			"public_id": "",
			"role": "",
			"is_in_person": false,
			"order": 0,
			"signer_group_id": null,
			"inputs": ...
		}
	],
      ...
}

Checklist

  • [✅] My code follows the style guidelines of this project
  • [✅] I have performed a self-review of my own changes
  • [✅] I have run yarn lint to make sure my changes pass all linters
  • [✅] I have pulled the latest changes from the upstream developer branch

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nathan Tymofichuk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@goome126 goome126 changed the title Added label field to TemplateSigner schema fix: Added label field to TemplateSigner schema Aug 14, 2024
@bszwarc
Copy link
Collaborator

bszwarc commented Aug 19, 2024

Closing this one - the repo is now read-only, any changes should be introduced to our internal api service repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants