Updating JCommander to 1.78 #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comunacho
commented
Jul 27, 2020
| @@ -345,7 +345,6 @@ public void importXcodeXliff() throws Exception { | |||
|
|
|||
| getL10nJCommander().run("push", "-r", repository.getName(), | |||
| "-s", getInputResourcesTestDir("source").getAbsolutePath(), | |||
| "-t", getInputResourcesTestDir("translations").getAbsolutePath(), | |||
There was a problem hiding this comment.
The Push command doesn't have any -t parameter
aurambaj
reviewed
Jul 27, 2020
| @@ -206,7 +206,8 @@ public void createJCommanderForRun() { | |||
| logger.debug("Create JCommander instance"); | |||
| jCommander = new JCommander(); | |||
|
|
|||
| jCommander.setAcceptUnknownOptions(true); | |||
| // TODO: Cant enable this until https://github.com/cbeust/jcommander/issues/377 is fixed | |||
| // jCommander.setAcceptUnknownOptions(true); | |||
There was a problem hiding this comment.
I think that was used to pass extra configuration to spring ... not sure if it is actually used today
There was a problem hiding this comment.
@jeeyi Is this used on your side?
| @@ -119,7 +119,7 @@ public Long answer(InvocationOnMock invocation) throws Throwable { | |||
|
|
|||
| localizeDropFiles(dropRepository.findById(dropId).orElse(null)); | |||
|
|
|||
| l10nJCommander.run(new String[]{"drop-import", "-r", repository.getName(), "--number-drop-fetched", "1000"}); | |||
aurambaj
force-pushed
the
spring2x
branch
6 times, most recently
from
b0d9400 to
87ad622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #612
There's a known issue with
jCommander.setAcceptUnknownOptions(true), described here. Disabling that option and updating tests that were using unknown parameters helped to get a green build.