Check type annotations in tests via typeguard #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedie
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 94.10% 94.17% +0.07%
==========================================
Files 50 50
Lines 1458 1460 +2
Branches 241 241
==========================================
+ Hits 1372 1375 +3
+ Misses 86 85 -1 ☔ View full report in Codecov by Sentry. |
Activate typeguard by `install_import_hook()` in `bx_py_utils_tests/tests/__init__.py` so it's activated for unittests, only. Fix some wrong typehints. Mainly missing ` | None` in optional keyword arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activate typeguard by
install_import_hook()inbx_py_utils_tests/tests/__init__.pyso it'sactivated for unittests, only.
Fix some wrong typehints. Mainly missing
| Nonein optional keyword arguments.