Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#91 update parent_task.update_dt on subtask signal #99

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Skrattoune
Copy link
Contributor

cf #91: update update_dt of the parent task when a signal is received from a sub-task

cf boxine#91: update update_dt of the parent task when a signal is received from a sub-task
@Skrattoune
Copy link
Contributor Author

The reason why we should have this test to fail is unclear to me.
It seems it is linked to the failing test ... which is not failing anymore !?!

@Skrattoune
Copy link
Contributor Author

2 errors:
image

process is slower than expected
Not sure why it should be tested? but maybe I misunderstood

image

the 3 sub-tasks seem to be stil executing

@Skrattoune
Copy link
Contributor Author

Need your input @jedie

@jedie
Copy link
Collaborator

jedie commented Apr 11, 2022

2 errors: image

This is because you add another timezone.now() in the code: Every call of this will increment the mocked datetime and the calculated values changed. You just have to update the calculated values in the test.

image

the 3 sub-tasks seem to be stil executing

Hm. I don't know and have to investigate this.

@@ -7,6 +7,7 @@
import uuid
from functools import lru_cache

from django.utils import timezone
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants