Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement variable suggestions #791

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Implement variable suggestions #791

merged 6 commits into from
Oct 12, 2023

Conversation

barmac
Copy link
Member

@barmac barmac commented Oct 6, 2023

Screen.Recording.2023-10-06.at.15.35.15.mov
  • variable suggestions are available in input expression
  • variable suggestions are available in table cell
  • variable suggestions are available in literal expression

Closes #785

@barmac barmac requested review from a team, marstamm and smbea and removed request for a team October 6, 2023 12:44
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 6, 2023
@barmac barmac marked this pull request as ready for review October 6, 2023 13:29
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 6, 2023
@marstamm
Copy link
Contributor

Works great, love the feature! Have you considered adding an integration test for the feature?

@barmac
Copy link
Member Author

barmac commented Oct 11, 2023

Works great, love the feature! Have you considered adding an integration test for the feature?

What would it test?

@marstamm
Copy link
Contributor

I was thinking that we could check that variables are passed to the Editor component, if that is manageable. If not, feel free to merge anyway

@barmac
Copy link
Member Author

barmac commented Oct 12, 2023

@marstamm Check out 1b2efbf

@barmac barmac merged commit 293ffea into develop Oct 12, 2023
5 checks passed
@barmac barmac deleted the 785-variable-suggestions branch October 12, 2023 12:19
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 12, 2023
@nikku
Copy link
Member

nikku commented Oct 12, 2023

Amazing stuff! 🎉

@nikku
Copy link
Member

nikku commented Oct 12, 2023

Let's ship it ⛵

@barmac barmac mentioned this pull request Oct 13, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement variable suggestions
3 participants