Replace title tag in SVG with aria-labelledby #2777
Conversation
jasinskidev
requested review from
krzotki,
Fasosnql,
thomsa and
radekwarisch
as code owners
| <title> | ||
| add more | ||
| </title> | ||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512" aria-labbeledby="add more"> |
There was a problem hiding this comment.
this should not be aria-labelledby (btw. there's a typo here) but aria-label. aria-labelledby needs another item with the id provided between "" to be able to label this element
There was a problem hiding this comment.
That what's happening when you blindly copy paste from the docs without thinking 😄 Yes I know, I will change it, thanks!
There was a problem hiding this comment.
but to be honest I'm not sure if the svg does actually need any label - it just has a presentational role. I'd suggest to give it alt="" as this suggests to the screen readers that it doesn't matter for the page content
|
i'd would advise to remove |
The only thing that this PR does is to replace title tag in SVGs with aria-labelledby.
Why? We had complaints from SEO team about this and their recommendation was to use one unified title tag or delete it.
I investigated that and official documentation says that title tag is not recommended and we should use aria-labelledby so I replaced it in every SVG with title tag.