Rename PayPal APIs #817
Merged
Rename PayPal APIs #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
reviewed
Nov 6, 2023
| @@ -46,8 +46,8 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c | |||
| braintreeClient = getBraintreeClient(); | |||
| payPalClient = new PayPalClient(braintreeClient); | |||
| payPalLauncher = new PayPalLauncher( | |||
| payPalBrowserSwitchResult -> payPalClient.onBrowserSwitchResult( | |||
| payPalBrowserSwitchResult, (payPalAccountNonce, error) -> { | |||
| payPalPaymentAuthResult -> payPalClient.tokenize( | |||
There was a problem hiding this comment.
Suggested change
| payPalPaymentAuthResult -> payPalClient.tokenize( | |
| payPalAuthResult -> payPalClient.tokenize( |
nit: Maybe we can make it more concise by removing the word payment?
There was a problem hiding this comment.
Do you mean rename the entire class or just the variables in these callbacks? I renamed the variables to paymentAuthResult to make it more concise. I think AuthResult might be a little too generic for the types but open to opinions on that.
There was a problem hiding this comment.
Yeah I guess the overall naming convention in general to be more specific. I get that adding the word payment may make it more descriptive though. Total take or leave.
I've got the Swift naming guidelines in mind. I find it to be a useful grammatical guide to naming in any language even though it's geared towards Swift.
sshropshire
approved these changes
Nov 6, 2023
scannillo
reviewed
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors