update logic to remove hardcoding of paymentType from app switch flows

braintree · Jul 30, 2024 · c15d3aa · c15d3aa
1 parent 4e46ba8
commit c15d3aa
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/Sources/BraintreePayPal/BTPayPalClient.swift b/Sources/BraintreePayPal/BTPayPalClient.swift
@@ -291,7 +291,12 @@ import BraintreeDataCollector
 
         switch returnURL.state {
         case .succeeded, .canceled:
-            handleReturn(url, paymentType: .vault, completion: appSwitchCompletion)
+            guard let payPalRequest else {
+                notifyFailure(with: BTPayPalError.missingPayPalRequest, completion: appSwitchCompletion)
+                return
+            }
+
+            handleReturn(url, paymentType: payPalRequest.paymentType, completion: appSwitchCompletion)
         case .unknownPath:
             notifyFailure(with: BTPayPalError.appSwitchReturnURLPathInvalid, completion: appSwitchCompletion)
         }
@@ -443,6 +448,7 @@ import BraintreeDataCollector
                     notifyFailure(with: BTPayPalError.missingPayPalRequest, completion: appSwitchCompletion)
                     return
                 }
+
                 handleReturn(url, paymentType: payPalRequest.paymentType, completion: completion)
             case .unknownPath:
                 notifyFailure(with: BTPayPalError.asWebAuthenticationSessionURLInvalid(url.absoluteString), completion: completion)