Clean up BTAPIClient.init (#1356)

* Clean up initializer * Fix UTs
braintree · Jul 8, 2024 · cf696aa · cf696aa
1 parent d93bd06
commit cf696aa
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 11 deletions.
diff --git a/Sources/BraintreeCore/BTAPIClient.swift b/Sources/BraintreeCore/BTAPIClient.swift
@@ -38,11 +38,7 @@ import Foundation
     /// Initialize a new API client.
     /// - Parameter authorization: Your tokenization key or client token. Passing an invalid value may return `nil`.
     @objc(initWithAuthorization:)
-    public convenience init?(authorization: String) {
-        self.init(authorization: authorization, sendAnalyticsEvent: true)
-    }
-
-    init?(authorization: String, sendAnalyticsEvent: Bool) {
+    public init?(authorization: String) {
         self.metadata = BTClientMetadata()
 
         guard let authorizationType = Self.authorizationType(for: authorization) else { return nil }

diff --git a/UnitTests/BraintreeApplePayTests/BTConfiguration+ApplePay_Tests.swift b/UnitTests/BraintreeApplePayTests/BTConfiguration+ApplePay_Tests.swift
@@ -5,7 +5,7 @@ import PassKit
 @testable import BraintreeTestShared
 
 class BTConfiguration_ApplePay_Tests : XCTestCase {
-    var mockAPIClient = MockAPIClient.init(authorization: "development_tokenization_key", sendAnalyticsEvent: false)!
+    var mockAPIClient = MockAPIClient.init(authorization: "development_tokenization_key")!
 
     func testIsApplePayEnabled_whenApplePayStatusFromConfigurationJSONIsAString_returnsTrue() {
         for applePayStatus in ["mock", "production", "asdfasdf"] {

diff --git a/UnitTests/BraintreeCoreTests/Analytics/BTAnalyticsService_Tests.swift b/UnitTests/BraintreeCoreTests/Analytics/BTAnalyticsService_Tests.swift
@@ -48,7 +48,7 @@ final class BTAnalyticsService_Tests: XCTestCase {
     // MARK: - Helper Functions
 
     func stubbedAPIClientWithAnalyticsURL(_ analyticsURL: String? = nil) -> MockAPIClient {
-        let stubAPIClient = MockAPIClient(authorization: "development_tokenization_key", sendAnalyticsEvent: false)
+        let stubAPIClient = MockAPIClient(authorization: "development_tokenization_key")
 
         if analyticsURL != nil {
             stubAPIClient?.cannedConfigurationResponseBody = BTJSON(

diff --git a/UnitTests/BraintreeTestShared/MockAPIClient.swift b/UnitTests/BraintreeTestShared/MockAPIClient.swift
@@ -27,10 +27,6 @@ public class MockAPIClient: BTAPIClient {
     var fetchedPaymentMethods = false
     var fetchPaymentMethodsSorting = false
 
-    override init?(authorization: String, sendAnalyticsEvent: Bool = false) {
-        super.init(authorization: authorization, sendAnalyticsEvent: sendAnalyticsEvent)
-    }
-
     public override func get(_ path: String, parameters: Encodable?, httpType: BTAPIClientHTTPService, completion completionBlock: ((BTJSON?, HTTPURLResponse?, Error?) -> Void)? = nil) {
         lastGETPath = path
         lastGETParameters = try? parameters?.toDictionary()