[Open Dev] Provide Default View Controller #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
commented
Mar 8, 2024
| @@ -188,7 +188,7 @@ class ContainmentViewController: UIViewController { | |||
|
|
|||
| private func instantiateViewController(with authorization: String) -> BaseViewController? { | |||
| guard let integrationName = UserDefaults.standard.string(forKey: "BraintreeDemoSettingsIntegration") else { | |||
| return nil | |||
| return PayPalWebCheckoutViewController(authorization: authorization) | |||
There was a problem hiding this comment.
PayPal Web made the most sense as the default to me, but if someone feels strongly that we should default to one of the other features, happy to do so!
scannillo
approved these changes
Mar 13, 2024
sshropshire
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Right now if the
FeatureViewControllercannot be found, a message is displayed "Demo not available", by providing a default asPayPalWebCheckoutViewControllerwe can load a View Controller instead of returningnilwithout a super clear message to the user. This is mainly helpful for first time installs, when nothing is stored inUserDefaultsyet or when switching between feature branches where the demo exists on a branch but not on main.Checklist
[ ] Added a changelog entryAuthors