Bumped Xcode Version to 15.0 #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
approved these changes
Mar 12, 2024
…o xcode-version-change # Conflicts: # CHANGELOG.md
|
Also bumped Xcode and MacOS versions in the script |
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Co-authored-by: Jax DesMarais-Leder <[email protected]>
1 task
scannillo
reviewed
Mar 18, 2024
README.md
Outdated
| @@ -10,7 +10,7 @@ Welcome to Braintree's iOS SDK. This library will help you accept card and alter | |||
|
|
|||
| v6 is the latest major version of Braintree iOS. To update from v5, see the [v6 migration guide](https://github.com/braintree/braintree_ios/blob/main/V6_MIGRATION.md). If you have not yet migrated to v5, see the [v5 migration guide](https://github.com/braintree/braintree_ios/blob/5.x/V5_MIGRATION.md) | |||
|
|
|||
| **The Braintree iOS SDK permits a deployment target of iOS 14.0 or higher**. It requires Xcode 14.3+ and Swift 5.8+. | |||
| **The Braintree iOS SDK permits a deployment target of iOS 14.0 or higher**. It requires Xcode 15.0+ and Swift 5.8+. | |||
There was a problem hiding this comment.
By requiring Xcode 15, aren't we also able to require Swift 5.9+?
There was a problem hiding this comment.
Yes, just realized that. I'll make the update
…o xcode-version-change # Conflicts: # CHANGELOG.md
…raintree_ios into xcode-version-change
|
Do we have a ticket for doing this on V5 as well? |
scannillo
approved these changes
Mar 19, 2024
…o xcode-version-change # Conflicts: # CHANGELOG.md
scannillo
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Bumped Xcode version to 15.0 * Bumped Xcode and MacOS versions * Changed MacOS YAML label Co-authored-by: Jax DesMarais-Leder <[email protected]> * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors