Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scene(_:willConnectTo:options:) to the MockVenmo App #1290

Closed
wants to merge 1 commit into from
Closed

Add scene(_:willConnectTo:options:) to the MockVenmo App #1290

wants to merge 1 commit into from

Conversation

richherrera
Copy link
Contributor

Summary of changes

  • The UITs sometimes failed because the MockVenmo app was not running, causing AppSwitcher. openVenmoURL to be nil. This PR adds scene(_:willConnectTo:options:). When the app is launched for the first time, it calls scene(_:willConnectTo:options:)

Apple Docs:

If your app has opted into Scenes, and your app is not running, the system delivers the URL to the scene(:willConnectTo:options:) delegate method after launch, and to scene(:openURLContexts:) when your app opens a URL while running or suspended in memory.

Checklist

  • Added a changelog entry

Authors

@richherrera richherrera requested a review from a team as a code owner May 3, 2024 20:10
@richherrera richherrera changed the title Add scene(_:willConnectTo:options:) to the MockVenmoApp Add scene(_:willConnectTo:options:) to the MockVenmoApp May 3, 2024
@richherrera richherrera changed the title Add scene(_:willConnectTo:options:) to the MockVenmoApp Add scene(_:willConnectTo:options:) to the MockVenmo App May 3, 2024
@jaxdesmarais jaxdesmarais mentioned this pull request Jul 12, 2024
Merged
@jaxdesmarais
Copy link
Contributor

Added this logic to #1345 - closing in favor of that PR that fully fixes UI Test flakiness with some additional changes

jaxdesmarais added a commit that referenced this pull request Jul 16, 2024
@jaxdesmarais
Fix UI Tests (#1345)
f794bdc 
* Updates to have UI Tests pass as expected
* Adds changes from PR Test Venmo UI tests in CI/CD #1328 and Add scene(_:willConnectTo:options:) to the MockVenmo App #1290
* Bumps timeouts
@jaxdesmarais jaxdesmarais deleted the fix_venmo_uits branch August 1, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richherrera @jaxdesmarais