Add customFields for 3DS verifyCard #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scannillo
reviewed
Jun 24, 2024
| @@ -11,6 +11,9 @@ import BraintreeCore | |||
|
|
|||
| /// A nonce to be verified by ThreeDSecure | |||
| public var nonce: String? | |||
|
|
|||
| /// Object where each key is the name of a custom field which has been configured in the Control Panel. In the Control Panel you can configure 3D Secure Rules which trigger on certain values. | |||
| public var customFields: [String: Any]? = [:] | |||
There was a problem hiding this comment.
Similar comment to here, with making this a more standard type that merchants use to model JSON - Encodable. A dictionary will also work though.
Which do you think is better merchant dev-ex?
There was a problem hiding this comment.
I just got more information that we'll be supporting no nested JSON values and n number of custom values. I'm waiting on clarification to determine if we're expecting only String values.
There was a problem hiding this comment.
Confirmed we can enforce string key values. I think [String: String] is fine. The merchant will be setting these values in their control panel. Btw, the Cardinal team is taking anything but stringifying everything coming through the gateway.
sshropshire
reviewed
Jun 24, 2024
sshropshire
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Accept a raw JSON format for customFields in BTThreeDSecureRequest for VerifyCard.
Checklist
Authors
@agedd
@jwarmkessel
@warmkesselj