Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Authorization argument in ConfigurationLoader.getConfig method #1361

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Remove Authorization argument in ConfigurationLoader.getConfig method #1361

merged 8 commits into from
Jul 16, 2024

Conversation

scannillo
Copy link
Contributor

@scannillo scannillo commented Jul 11, 2024 •
edited
Loading

Summary of changes

  • Remove authorization argument from ConfigurationLoader.getConfig() method since the authorization is already available on the BTHTTP instance (which is required via the ConfigurationLoader.init)
  • This will help in a following PR to ensure the GET requests triggered from ConfigurationLoader are idempotent

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo
Remove unneeded authorization param on ConfigurationLoader.get() meth…
ce3887e 
…od; use authorization on associated BTHTTP instead
@scannillo scannillo marked this pull request as ready for review July 11, 2024 15:28
@scannillo scannillo requested a review from a team as a code owner July 11, 2024 15:28
@scannillo scannillo changed the title Cleanup - Remove Authorization argument in ConfigurationLoader.getConfig method Remove Authorization argument in ConfigurationLoader.getConfig method Jul 11, 2024
scannillo and others added 7 commits July 11, 2024 12:39
@scannillo @jaxdesmarais
Update Sources/BraintreeCore/BTAPIClient.swift
fc32c19 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@scannillo @jaxdesmarais
Update UnitTests/BraintreeCoreTests/ConfigurationLoader_Tests.swift
53f8208 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@scannillo @jaxdesmarais
Update UnitTests/BraintreeCoreTests/ConfigurationLoader_Tests.swift
257c62d 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@scannillo @jaxdesmarais
Update UnitTests/BraintreeCoreTests/ConfigurationLoader_Tests.swift
394e0cc 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@scannillo @jaxdesmarais
Update UnitTests/BraintreeCoreTests/ConfigurationLoader_Tests.swift
6679562 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@scannillo @jaxdesmarais
Update UnitTests/BraintreeCoreTests/ConfigurationLoader_Tests.swift
550b203 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@scannillo @jaxdesmarais
Update Sources/BraintreeCore/ConfigurationLoader.swift
f7d4d61 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
agedd
agedd approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@scannillo scannillo merged commit aa394b1 into main Jul 16, 2024
6 of 7 checks passed
@scannillo scannillo deleted the config-loader-blocking branch July 16, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agedd agedd agedd approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@KunJeongPark KunJeongPark KunJeongPark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scannillo @KunJeongPark @jaxdesmarais @agedd