[OPEN DEV] Add Swiftlint to BraintreeCore
#1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
changed the title
BraintreeCoreBraintreeCore
scannillo
reviewed
Jul 15, 2024
scannillo
reviewed
Jul 15, 2024
scannillo
approved these changes
Jul 15, 2024
agedd
reviewed
Jul 15, 2024
warmkesselj
approved these changes
Jul 15, 2024
Co-authored-by: agedd <[email protected]>
jaxdesmarais
commented
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
swiftlint.ymlto GitHub workflows.swiftlint.ymlfile with ruleset - this ruleset is the same as PPCPswiftlintBraintreeCore- will enable 1 module at a time to make PRs easier to reason about, additionally this allow us to progressively enable Swiftlint across the SDK while ensure code changes in modules where it's enable are compliantChecklist
[ ] Added a changelog entryAuthors